Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close stream #421

Merged
merged 1 commit into from
Oct 13, 2023
Merged

close stream #421

merged 1 commit into from
Oct 13, 2023

Conversation

DavidBadura
Copy link
Member

Currently the streams are left open, which means that the connection is never closed. This particularly affects long-term processes. This PR ensures that the streams are closed even after use.

@DavidBadura DavidBadura added the bug Something isn't working label Oct 13, 2023
@DavidBadura DavidBadura added this to the 3.0.0 milestone Oct 13, 2023
@github-actions
Copy link

Hello 👋

here is the most recent benchmark result: 

LoadEventsBench
===============

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 123.056ms (±0.00%) | 124.448ms (±0.00%) | 13.532mb        | 13.531mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

WriteEventsWithSyncProjectionistBench
=====================================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchSave1Event ()      | 1.788ms (±0.00%)   | 1.693ms (±0.00%)   | 7.264mb         | 7.263mb    |
| benchSave10000Events () | 704.449ms (±0.00%) | 700.846ms (±0.00%) | 14.656mb        | 14.655mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

WriteEventsBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchSave1Event ()      | 1.008ms (±0.00%)   | 1.393ms (±0.00%)   | 7.094mb         | 7.093mb    |
| benchSave10000Events () | 537.695ms (±0.00%) | 537.093ms (±0.00%) | 14.010mb        | 14.009mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

LoadEventsWithSnapshotsBench
============================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 213.600μs (±0.00%) | 210.750μs (±0.00%) | 13.562mb        | 13.561mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura merged commit 0923b9d into 3.0.x Oct 13, 2023
26 of 27 checks passed
@DavidBadura DavidBadura deleted the close-stream branch October 13, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBadura DanielBadura DanielBadura approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidBadura @DanielBadura